viirya commented on code in PR #209:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/209#discussion_r1527206381
##########
dev/diffs/3.4.2.diff:
##########
@@ -976,25 +980,18 @@ index 266bb343526..85ec36db996 100644
val bucketColumnType =
bucketedDataFrame.schema.apply(bucketColumnIndex).dataType
val rowsWithInvalidBuckets = fileScan.execute().filter(row => {
-@@ -461,18 +471,29 @@ abstract class BucketedReadSuite extends QueryTest with
SQLTestUtils with Adapti
+@@ -461,18 +472,22 @@ abstract class BucketedReadSuite extends QueryTest with
SQLTestUtils with Adapti
// check existence of shuffle
assert(
- joinOperator.left.exists(_.isInstanceOf[ShuffleExchangeExec]) ==
shuffleLeft,
-+ joinOperator.left.find { op =>
-+ op.isInstanceOf[SortExec] ||
-+ (op.isInstanceOf[CometExec] &&
-+
op.asInstanceOf[CometExec].originalPlan.find(_.isInstanceOf[SortExec]).isDefined)
-+ }.isDefined == sortLeft,
-+
++ joinOperator.left.exists(op => op.isInstanceOf[ShuffleExchangeExec]
||
Review Comment:
For `op.isInstanceOf[ShuffleExchangeExec]`, don't we need to check if it
equals to `shuffleLeft`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
