tyrelr commented on a change in pull request #9440:
URL: https://github.com/apache/arrow/pull/9440#discussion_r571710843
##########
File path: rust/arrow/src/compute/kernels/comparison.rs
##########
@@ -33,56 +33,66 @@ use crate::datatypes::{ArrowNumericType, DataType};
use crate::error::{ArrowError, Result};
use crate::util::bit_util;
-/// Helper function to perform boolean lambda function on values from two
arrays, this
-/// version does not attempt to use SIMD.
-macro_rules! compare_op {
- ($left: expr, $right:expr, $op:expr) => {{
- if $left.len() != $right.len() {
+fn infallible_compare_operation_scalar<'a,A,S,F>(left:&'a A, right: S,
predicate:F) -> Result<BooleanArray>
Review comment:
This function name is misleading, should probably rename it back to the
name the macro used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
