AliKhalili commented on PR #40554: URL: https://github.com/apache/arrow/pull/40554#issuecomment-2002532993
my bad, I had to replace the generic logger with a non-generic one as well which I forgot. > is it possible for CreateLogger to return an ILogger which isn't an ILogger? no, it is not, as I explained in its issue, we should avoid using the generic `CreateLogger` which each time initializes a new object but the non-generic one uses a built-in in-memory caching with avoid redundant allocation each time we request a new instance of `FlightSqlServer`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
