viirya commented on code in PR #5525:
URL: https://github.com/apache/arrow-rs/pull/5525#discussion_r1527645739
##########
arrow-ipc/src/reader.rs:
##########
@@ -79,6 +83,16 @@ fn create_array(reader: &mut ArrayReader, field: &Field) ->
Result<ArrayRef, Arr
reader.next_buffer()?,
],
),
+ BinaryView | Utf8View => {
+ let count = variadic_counts
+ .pop_front()
+ .expect("Incorrect variadic count!");
Review Comment:
Instead of panic, I think it is better to propagate an `Err`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
