korowa commented on PR #9676: URL: https://github.com/apache/arrow-datafusion/pull/9676#issuecomment-2004321116
Regarding benchmarks -- this PR affects q11 and q22 in tpch, but the results differ much for tpch and tpch_mem (tpch_mem statistics estimations differ from ones in tpch over parquet files): <details> <summary>tpch_mem</summary> ``` ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ master ┃ nl_join_reorder ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 11 │ 40.20ms │ 60.53ms │ 1.51x slower │ │ QQuery 22 │ 39.90ms │ 48.82ms │ 1.22x slower │ └──────────────┴──────────┴─────────────────┴───────────────┘ ``` </details> <details> <summary>tpch</summary> ``` ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ master ┃ nl_join_reorder ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 11 │ 65.86ms │ 37.58ms │ +1.75x faster │ │ QQuery 22 │ 69.01ms │ 72.40ms │ no change │ └──────────────┴──────────┴─────────────────┴───────────────┘ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
