judahrand commented on issue #36399: URL: https://github.com/apache/arrow/issues/36399#issuecomment-2004475739
I think there is also an open question as to what type `join` and `join_asof` should return. I'm not sure it makes sense for these methods to return a `RecordBatch` since, depending on the data and join type, they may return many more rows than either of the input `RecordBatches`. The obvious option would then be to return a `Table` or a `RecordBatchReader`. A `Table` might be more immediately useful to consumers as it allows for methods to be chained without calling `.read_all`, however, a `RecordBatchReader` in some ways makes more sense given that cases where the users is operating on a `RecordBatch` are likely to be cases where streaming type workflows are preferable. What do you think @jorisvandenbossche? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
