sunchao commented on code in PR #178:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/178#discussion_r1529007962
##########
common/src/main/java/org/apache/comet/vector/CometPlainVector.java:
##########
@@ -113,7 +113,11 @@ public UTF8String getUTF8String(int rowId) {
byte[] result = new byte[length];
Platform.copyMemory(
null, valueBufferAddress + offset, result,
Platform.BYTE_ARRAY_OFFSET, length);
- return UTF8String.fromString(convertToUuid(result).toString());
+ if (length == 16) {
+ return UTF8String.fromString(convertToUuid(result).toString());
+ } else {
+ return UTF8String.fromBytes(result);
+ }
Review Comment:
Yea, since Iceberg is not supported yet. We should think about how to
properly support UUID later. Currently it just check whether length is 16 and
treat it as UUID if so, which doesn't seem correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
