amoeba commented on code in PR #40022:
URL: https://github.com/apache/arrow/pull/40022#discussion_r1529465069
##########
.pre-commit-config.yaml:
##########
@@ -52,3 +53,9 @@ repos:
hooks:
- id: cython-lint
args: [--no-pycodestyle]
+ - repo: https://github.com/sphinx-contrib/sphinx-lint
+ rev: v0.9.1
+ hooks:
+ - id: sphinx-lint
+ files: ^docs/
+ args: ['--disable', 'all', '--enable',
'trailing-whitespace,missing-final-newline', 'docs']
Review Comment:
Nice change, thanks. Accepted.
I'm not sure about the extra docs arg but but maybe we don't. Good eye.
##########
.pre-commit-config.yaml:
##########
@@ -52,3 +53,9 @@ repos:
hooks:
- id: cython-lint
args: [--no-pycodestyle]
+ - repo: https://github.com/sphinx-contrib/sphinx-lint
+ rev: v0.9.1
+ hooks:
+ - id: sphinx-lint
+ files: ^docs/
+ args: ['--disable', 'all', '--enable',
'trailing-whitespace,missing-final-newline', 'docs']
Review Comment:
Nice change, thanks. Accepted.
I'm not sure about the extra docs arg but but maybe we don't need it since
we already filter on path. Good eye.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
