pitrou commented on code in PR #40094:
URL: https://github.com/apache/arrow/pull/40094#discussion_r1530094553
##########
cpp/src/arrow/util/byte_stream_split_internal.h:
##########
@@ -492,45 +501,94 @@ inline void DoMergeStreams(const uint8_t** src_streams,
int width, int64_t nvalu
}
template <int kNumStreams>
-void ByteStreamSplitEncodeScalar(const uint8_t* raw_values, const int64_t
num_values,
- uint8_t* output_buffer_raw) {
+void ByteStreamSplitEncodeScalar(const uint8_t* raw_values, int width,
+ const int64_t num_values, uint8_t* out) {
+ assert(width == kNumStreams);
std::array<uint8_t*, kNumStreams> dest_streams;
for (int stream = 0; stream < kNumStreams; ++stream) {
- dest_streams[stream] = &output_buffer_raw[stream * num_values];
+ dest_streams[stream] = &out[stream * num_values];
}
DoSplitStreams(raw_values, kNumStreams, num_values, dest_streams.data());
}
+inline void ByteStreamSplitEncodeScalarDynamic(const uint8_t* raw_values, int
width,
+ const int64_t num_values,
uint8_t* out) {
+ ::arrow::internal::SmallVector<uint8_t*, 16> dest_streams;
+ dest_streams.resize(width);
+ for (int stream = 0; stream < width; ++stream) {
+ dest_streams[stream] = &out[stream * num_values];
+ }
+ DoSplitStreams(raw_values, width, num_values, dest_streams.data());
+}
+
template <int kNumStreams>
-void ByteStreamSplitDecodeScalar(const uint8_t* data, int64_t num_values,
int64_t stride,
- uint8_t* out) {
+void ByteStreamSplitDecodeScalar(const uint8_t* data, int width, int64_t
num_values,
+ int64_t stride, uint8_t* out) {
+ assert(width == kNumStreams);
std::array<const uint8_t*, kNumStreams> src_streams;
for (int stream = 0; stream < kNumStreams; ++stream) {
src_streams[stream] = &data[stream * stride];
}
DoMergeStreams(src_streams.data(), kNumStreams, num_values, out);
}
-template <int kNumStreams>
-void inline ByteStreamSplitEncode(const uint8_t* raw_values, const int64_t
num_values,
- uint8_t* output_buffer_raw) {
+inline void ByteStreamSplitDecodeScalarDynamic(const uint8_t* data, int width,
+ int64_t num_values, int64_t
stride,
+ uint8_t* out) {
+ ::arrow::internal::SmallVector<const uint8_t*, 16> src_streams;
+ src_streams.resize(width);
+ for (int stream = 0; stream < width; ++stream) {
+ src_streams[stream] = &data[stream * stride];
+ }
+ DoMergeStreams(src_streams.data(), width, num_values, out);
+}
+
+inline void ByteStreamSplitEncode(const uint8_t* raw_values, int width,
+ const int64_t num_values, uint8_t* out) {
#if defined(ARROW_HAVE_SIMD_SPLIT)
- return ByteStreamSplitEncodeSimd<kNumStreams>(raw_values, num_values,
- output_buffer_raw);
+#define ByteStreamSplitEncodePerhapsSimd ByteStreamSplitEncodeSimd
#else
- return ByteStreamSplitEncodeScalar<kNumStreams>(raw_values, num_values,
- output_buffer_raw);
+#define ByteStreamSplitEncodePerhapsSimd ByteStreamSplitEncodeScalar
#endif
+ switch (width) {
+ case 1:
+ memcpy(out, raw_values, num_values);
Review Comment:
Well, yes, by definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
