sikan opened a new pull request #9453: URL: https://github.com/apache/arrow/pull/9453
The fix now adds single quotes around string literals when ToString() is called. It makes sure the string representation of an expression containing null is NOT identical with that of another expression where null is simply replaced by 'null'. Otherwise an incorrect filter might be returned from the cache due to the hash algorithm used by FilterCacheKey. Please note that if a string literal itself contains single quotes or other special characters, those are currently not escaped. Not quite sure if that would be necessary, as a string literal may even contain things like "(const string)" which would be much more confusing than a few special characters. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
