jonahgao commented on PR #9687: URL: https://github.com/apache/arrow-datafusion/pull/9687#issuecomment-2008544972
> Thus, what do you think about the idea of basically creating an entirely new `ExecutionPlan` via [`ExecutionPlan::with_new_children`](https://docs.rs/datafusion/latest/datafusion/physical_plan/trait.ExecutionPlan.html#tymethod.with_new_children)? > I've tried using `with_new_children` before, and I was concerned about its efficiency too. I also worried that it doesn't explicitly promise to clear the states in the plan, so I switched to the current solution. However, I couldn't decide which was better, as they both had their downsides. Thank you for your advice @alamb , I agree that using `ExecutionPlan::with_new_children` would be better, it's safer and it does not introduce extra complexity from new API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
