wiedld commented on code in PR #9685:
URL: https://github.com/apache/arrow-datafusion/pull/9685#discussion_r1531566365
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -719,23 +741,10 @@ impl TreeNodeRewriter for CommonSubexprRewriter<'_> {
));
}
- let (series_number, id) = &self.id_array[self.curr_index];
+ // incr idx for id_array, when not jumping
self.curr_index += 1;
- // Skip sub-node of a replaced tree, or without
identifier, or is not repeated expr.
- let expr_set_item = self.expr_set.get(id).ok_or_else(|| {
- internal_datafusion_err!("expr_set invalid state")
- })?;
- if *series_number < self.max_series_number
Review Comment:
These checks are already done earlier. Remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
