paleolimbot commented on code in PR #405:
URL: https://github.com/apache/arrow-nanoarrow/pull/405#discussion_r1532136281


##########
CMakeLists.txt:
##########
@@ -18,6 +18,11 @@
 message(STATUS "Building using CMake version: ${CMAKE_VERSION}")
 cmake_minimum_required(VERSION 3.14)
 
+# Try to use C11 (required by IPC extension) but fall back to C99

Review Comment:
   I put it in because the flatbuffer implementation ( 
https://github.com/dvidelabs/flatcc ) uses come C11 features, although now that 
I read the documentation, it seems like it just requires some extra includes to 
work with C99. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to