emkornfield commented on a change in pull request #9368: URL: https://github.com/apache/arrow/pull/9368#discussion_r573037004
########## File path: format/FlightSQL.proto ########## @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +syntax = "proto3"; + +option java_package = "org.apache.arrow.flight.sql.impl"; +package arrow.flight.protocol.sql; + +/* + * Wrapper for the result of a "GetSQLInfo" action. + */ +message ActionGetSQLInfoResult { + /* + * Values are modelled after ODBC's SQLGetInfo() function. This information is intended to provide + * Flight SQL clients with basic, SQL syntax and SQL functions related information. + * More information types can be added in future releases. + * E.g. more SQL syntax support types, scalar functions support, type conversion support etc. + * + * Initially, Flight SQL will support the following information types: + * - Server Information + * - + * + * 1. Server Information: Provides basic information about the Flight SQL Server. + * + * The name of the Flight SQL Server. + * FLIGHT_SQL_SERVER_NAME Review comment: I assume these are intended to be keys in the maps below? For some of them should they be promoted to first class concepts? Per my comment above. I think I would have a preference for moving as much as possible to sql queries. so if we defined a special table like `__APACHE_FLIGHT_SQL_INFO__` with a schema { flight_sql_server_name: utf8 flight_sql_server_version: utf8 flight_sql_server_arrow_version: utf8 (or maybe modeled as a struct) flight_sql_info: map<utf8, dense_union<string_value: string, int_value: int32, bigint_value: int64, int32_bitmask: int32 >> } where the int32 bitmask would also have a defined extension metadata for a custom type of bitmask. The minimal table requirement is that it supports projection: i.e. only `select * from __APACHE_FLIGHT_SQL_INFO__` or `select FLIGHT_SQL_VERSION from __APACHE_FLIGHT_SQL_INFO__` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
