alamb commented on code in PR #9648:
URL: https://github.com/apache/arrow-datafusion/pull/9648#discussion_r1532616398
##########
datafusion/core/src/datasource/file_format/write/mod.rs:
##########
@@ -69,79 +66,6 @@ impl Write for SharedBuffer {
}
}
-/// Stores data needed during abortion of MultiPart writers
Review Comment:
Ok, so I vote we leave the code as is (no attempt to explicitly abort in
write) and add a note in the documentation. If it turns out this is an
important behavior, we can add it back in
@yyy1000 can you handle adding the note in the documentation
##########
datafusion/core/src/datasource/file_format/write/mod.rs:
##########
@@ -69,79 +66,6 @@ impl Write for SharedBuffer {
}
}
-/// Stores data needed during abortion of MultiPart writers
Review Comment:
Ok, so I vote we leave the code as is (no attempt to explicitly abort in
write) and add a note in the documentation. If it turns out this is an
important behavior, we can add it back in
@yyy1000 can you handle adding the note in the documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
