alamb commented on code in PR #9541:
URL: https://github.com/apache/arrow-datafusion/pull/9541#discussion_r1532743366
##########
datafusion/functions/Cargo.toml:
##########
@@ -29,19 +29,21 @@ authors = { workspace = true }
rust-version = { workspace = true }
[features]
+# enable string functions
+string_expressions = []
# enable core functions
core_expressions = []
# enable datetime functions
datetime_expressions = []
-# Enable encoding by default so the doctests work. In general don't
automatically enable all packages.
default = [
"core_expressions",
"datetime_expressions",
"encoding_expressions",
"math_expressions",
"regex_expressions",
"crypto_expressions",
-]
+ "string_expressions",
+] # Enable encoding by default so the doctests work. In general don't
automatically enable all packages.
Review Comment:
It seems strange the comment was moved down to the bottom. Shouldn't it
still be at the top?
##########
datafusion/core/tests/dataframe/dataframe_functions.rs:
##########
@@ -650,26 +650,6 @@ async fn test_fn_split_part() -> Result<()> {
Ok(())
}
-#[tokio::test]
Review Comment:
I poked around and this seems like it was because the `string_functions`
expr_fn weren't exported. I took the liberty of fixing this in b803062ef
##########
datafusion/core/tests/dataframe/dataframe_functions.rs:
##########
@@ -650,26 +650,6 @@ async fn test_fn_split_part() -> Result<()> {
Ok(())
}
-#[tokio::test]
Review Comment:
I don't understand why these tests were removed. I think it is important
that we can still use these functions with the dataframe API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
