huaxingao commented on code in PR #216:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/216#discussion_r1533068315
##########
common/src/main/scala/org/apache/spark/sql/comet/util/Utils.scala:
##########
@@ -69,6 +69,7 @@ object Utils {
case int: ArrowType.Int if int.getIsSigned && int.getBitWidth == 8 * 2 =>
ShortType
case int: ArrowType.Int if int.getIsSigned && int.getBitWidth == 8 * 4 =>
IntegerType
case int: ArrowType.Int if int.getIsSigned && int.getBitWidth == 8 * 8 =>
LongType
+ case int: ArrowType.Int if int.getBitWidth == 8 * 8 => LongType
Review Comment:
Since the max of UInt64 is 18446744073709551615, I guess we can use
`DecimalType(20, 0)` to represent the number without overflowing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
