jayzhan211 commented on PR #9710: URL: https://github.com/apache/arrow-datafusion/pull/9710#issuecomment-2011955412
How about extract the common to function. And, try to let the logic for one stay close together. One of issue I think that make it less readable is that for example array except, we need to go through several if else statements that is unrelated (union or intersect), and even swapping for the common function. I think I need suggestions from others too, maybe it is easy to read for others. On Thu, Mar 21, 2024, 6:14 PM Alex Huang ***@***.***> wrote: > @Weijun-H <https://github.com/Weijun-H> I think the common logic for them > is not large enough to worth mixing into one function. Do you think > separate the function for them is easier for understanding the code? I'm > even thinking of union and intersect too. > > The three function logic structures are similar, so I think they should be > merged into one. @jayzhan211 <https://github.com/jayzhan211> > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow-datafusion/pull/9710#issuecomment-2011833385>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADZCLR2LQ46JY6UGPDDTGJTYZKXKDAVCNFSM6AAAAABE7XPNPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRHAZTGMZYGU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
