alamb commented on code in PR #9722:
URL: https://github.com/apache/arrow-datafusion/pull/9722#discussion_r1534002193
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -50,6 +50,10 @@ pub trait ExprSchemable {
/// cast to a type with respect to a schema
fn cast_to(self, cast_to_type: &DataType, schema: &dyn ExprSchema) ->
Result<Expr>;
+
+ /// given a schema, return the type and nullability of the expr
+ fn data_type_and_nullable(&self, schema: &dyn ExprSchema)
+ -> Result<(DataType, bool)>;
Review Comment:
is there a reason this can't also return a reference like
```suggestion
-> Result<(&DataType, bool)>;
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
