wjones127 commented on code in PR #40708:
URL: https://github.com/apache/arrow/pull/40708#discussion_r1534211597
##########
docs/source/format/CDataInterface/PyCapsuleInterface.rst:
##########
@@ -142,6 +154,22 @@ Arrays and record batches (contiguous tables) can
implement the method
respectively. The schema capsule should have the name
``"arrow_schema"``
and the array capsule should have the name ``"arrow_array"``.
+Libraries supporting the Device interface can implement a
``__arrow_c_device_array__``
+method on those objects, which works the same as ``__arrow_c_array__`` except
+for returning a ArrowDeviceArray structure instead of a ArrowArray structure:
+
+.. py:method:: __arrow_c_device_array__(self, requested_schema: object | None
= None) -> Tuple[object, object]
Review Comment:
I'm fine removing them. In general, I like having the type hints as they
make signatures easy to understand from my human perspective. They can be less
ambiguous than a description of a type. But given we don't have a `PyCapsule`
type, I agree they don't add much value here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
