[GitHub] [arrow] alamb commented on a change in pull request #9456: ARROW-11574: [Rust][DataFusion] Upgrade sqlparser to support parsing all TPC-H queries

[GitBox]

alamb commented on a change in pull request #9456:
URL: https://github.com/apache/arrow/pull/9456#discussion_r573303633



##########
File path: rust/datafusion/src/sql/planner.rs
##########
@@ -2052,7 +2057,8 @@ mod tests {
     fn 
select_simple_aggregate_with_groupby_non_column_expression_nested_and_not_resolvable(
     ) {
         // The query should fail, because age + 9 is not in the group by.
-        let sql = "SELECT ((age + 1) / 2) * (age + 9), MIN(first_name) FROM 
person GROUP BY age + 1";
+        let sql =

Review comment:
       this looks like a whitespace only change

##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -386,7 +386,7 @@ fn create_logical_plan(ctx: &mut ExecutionContext, query: 
usize) -> Result<Logic
         //     where
         //         l_shipdate >= date '1994-01-01'
         //         and l_shipdate < date '1994-01-01' + interval '1' year
-        //         and l_discount between 0.06 - 0.01 and 0.06 + 0.01
+        //         and l_discount between .06 - 0.01 and .06 + 0.01

Review comment:
       I don't think it really matters, but my reading of the TPCH spec 
(validation query) has `0.06` rather than `.06`. 
   
   http://tpc.org/tpc_documents_current_versions/pdf/tpc-h_v2.18.0.pdf
   
   ![Screen Shot 2021-02-09 at 5 47 20 
PM](https://user-images.githubusercontent.com/490673/107438673-dd2ec780-6afe-11eb-97e2-c14d805fba5e.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org