alamb commented on issue #9530: URL: https://github.com/apache/arrow-datafusion/issues/9530#issuecomment-2013152034
> I think in the comet cases, the value type is a dict(i32, utf8) and the static list is all utf8 type. So we should convert the dict(i32, utf8) to utf8 instead? However, like you said, physical-expr is used directly in comet, it might not be possible to covert the value type beforehand. I can think of two possibilities ## Option 1 Easy to code, less performant `cast` the argument from `Dict(Int, Utf8)` to `Utf8` (using [cast](https://docs.rs/datafusion/latest/datafusion/physical_plan/expressions/fn.cast.html)) ## More code, but more performant Implement direct support for `Dictionary` types in the Inlist physical expression implementation Somewhere in here: https://docs.rs/datafusion-physical-expr/36.0.0/src/datafusion_physical_expr/expressions/in_list.rs.html#146-210 (this would also help us in InfluxData so I would be happy to help review / work on a PR -- though my bandwidth for the next week is pretty limited) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
