dioptre commented on PR #40729: URL: https://github.com/apache/arrow/pull/40729#issuecomment-2014236633
Are the tests off? I’ll take a look soon. I made it so you pass the denominator through instead of scale. The reason for this is that with 10^9 numbers to convert you don’t need to do a scale to denominator conversion for each number. Passing the denominator as a bigint instead will make the function much faster. On Thu, Mar 21, 2024 at 19:27 Dominik Moritz ***@***.***> wrote: > vec.get(0).valueOf(1000n) return the correct value but it would be nice > to pass the scale though. It's in the type but I don't know what is the > best way to get that. This otherwise looks correct. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/40729#issuecomment-2014197628>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAFZTGAX2QDJV7ECPJO3IW3YZOJHNAVCNFSM6AAAAABFCPNKICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJUGE4TONRSHA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
