alamb commented on a change in pull request #9460:
URL: https://github.com/apache/arrow/pull/9460#discussion_r573652531
##########
File path: rust/arrow/src/compute/kernels/concat.rs
##########
@@ -390,4 +390,35 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn test_string_array_slices() -> Result<()> {
Review comment:
I ran these tests without the fix and they fail in this way:
```
---- compute::kernels::concat::tests::test_string_array_slices stdout ----
thread 'compute::kernels::concat::tests::test_string_array_slices' panicked
at 'range end index 8 out of range for slice of length 7',
arrow/src/array/transform/variable_size.rs:38:23
---- compute::kernels::concat::tests::test_string_array_with_null_slices
stdout ----
thread 'compute::kernels::concat::tests::test_string_array_with_null_slices'
panicked at 'range end index 6 out of range for slice of length 5',
arrow/src/array/transform/variable_size.rs:38:23
```
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
