westonpace commented on code in PR #40696:
URL: https://github.com/apache/arrow/pull/40696#discussion_r1535671639
##########
cpp/thirdparty/versions.txt:
##########
@@ -103,8 +103,8 @@ ARROW_RE2_BUILD_VERSION=2022-06-01
ARROW_RE2_BUILD_SHA256_CHECKSUM=f89c61410a072e5cbcf8c27e3a778da7d6fd2f2b5b1445cd4f4508bee946ab0f
ARROW_SNAPPY_BUILD_VERSION=1.1.10
ARROW_SNAPPY_BUILD_SHA256_CHECKSUM=49d831bffcc5f3d01482340fe5af59852ca2fe76c3e05df0e67203ebbe0f1d90
-ARROW_SUBSTRAIT_BUILD_VERSION=v0.27.0
-ARROW_SUBSTRAIT_BUILD_SHA256_CHECKSUM=4ed375f69d972a57fdc5ec406c17003a111831d8640d3f1733eccd4b3ff45628
+ARROW_SUBSTRAIT_BUILD_VERSION=v0.44.0
Review Comment:
I'm not aware of any. I left in support for consuming the legacy timestamp
type so there shouldn't be too much concern for backwards compatibility.
Although, I suppose if anyone is using serialize_expressions, they may see a
difference, so I suppose it is still technically a breaking change. But I'm
pretty confident there are no integration tests using serialize_expressions yet.
##########
cpp/src/arrow/engine/substrait/type_internal.cc:
##########
@@ -379,10 +455,13 @@ struct DataTypeToProtoImpl {
return NotImplemented(t);
}
+ // TODO(weston) support parameterized UDT
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
