alamb commented on code in PR #5541:
URL: https://github.com/apache/arrow-rs/pull/5541#discussion_r1536212668
##########
arrow-array/src/builder/fixed_size_list_builder.rs:
##########
@@ -179,22 +179,37 @@ where
self.list_len,
len,
);
+
+ let nulls = self.null_buffer_builder.finish();
+
let field = match &self.field {
- Some(f) => f.clone(),
+ Some(f) => {
+ assert_eq!(
+ f.data_type(),
+ values_data.data_type(),
+ "DataType of field ({}) should be the same as the
values_builder DataType ({})",
Review Comment:
👍
##########
arrow-array/src/builder/fixed_size_list_builder.rs:
##########
@@ -194,17 +212,23 @@ where
);
let nulls = self.null_buffer_builder.finish_cloned();
- let array_data = ArrayData::builder(DataType::FixedSizeList(
- Arc::new(Field::new("item", values_data.data_type().clone(),
true)),
- self.list_len,
- ))
- .len(len)
- .add_child_data(values_data)
- .nulls(nulls);
- let array_data = unsafe { array_data.build_unchecked() };
Review Comment:
Looks good 👍
##########
arrow-array/src/builder/fixed_size_list_builder.rs:
##########
@@ -247,6 +298,180 @@ mod tests {
assert_eq!(3, list_array.value_length());
}
+ #[test]
+ fn test_fixed_size_list_array_builder_with_field() {
+ let values_builder = Int32Builder::new();
+ let mut builder = FixedSizeListBuilder::new(values_builder,
3).with_field(Field::new(
+ "list_element",
+ DataType::Int32,
+ true,
+ ));
+
+ // [[0, 1, 2], null, [3, null, 5], [6, 7, null]]
+ builder.values().append_value(0);
+ builder.values().append_value(1);
+ builder.values().append_value(2);
+ builder.append(true);
+ builder.values().append_null();
+ builder.values().append_null();
+ builder.values().append_null();
+ builder.append(false);
+ builder.values().append_value(3);
+ builder.values().append_null();
+ builder.values().append_value(5);
+ builder.append(true);
+ builder.values().append_value(6);
+ builder.values().append_value(7);
+ builder.values().append_null();
+ builder.append(true);
Review Comment:
It might be nice to avoid repeating this same setup multiple times in the
tests (and it would make it clear the tests share the same data)
for example
```rust
fn make_list_builder() -> FixedSizedListBuilder<i32> {
...
}
```
```suggestion
let builder = make_list_builder();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
