alamb commented on PR #9729:
URL:
https://github.com/apache/arrow-datafusion/pull/9729#issuecomment-2016450858
Thanks for working on this @tshauck -- it is really cool to see
> Going to open this in draft, and will come back later today/tomorrow to
see what the basic strategy for constructing a LogicalPlan would look like and
see if that's a reasonable first chunk.
The simplest strategy I can think of is to implement your own version to
`sql_statement_to_plan` but for `MyStatement`
So something like
```
pub async fn my_statement_to_plan(
ctx: &SessionContext,
statement: MyStatement,
) -> Result<LogicalPlan> {
...
// call statement_to_plan here and implement the special Copy logic
}
````
> So I guess my questions are 1) does an Extension statement seem reasonable
to you? 2) and if so, any advice on the implementation to mitigate object
safety issues.
I don't fully understand the need for an Extension statement -- if the idea
is to wrap `DFStatement` with `MyStatement` I think you can just implement the
planning in terms of MyStatement as above.
If the idea is to avoid repetition with whatever statement_to_plan is doing,
maybe we can factor out the common functionality into a module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
