MohamedAbdeen21 commented on code in PR #9599:
URL: https://github.com/apache/arrow-datafusion/pull/9599#discussion_r1536632094
##########
datafusion/sqllogictest/test_files/create_external_table.slt:
##########
@@ -100,9 +100,17 @@ CREATE EXTERNAL TABLE t(c1 int) STORED AS CSV WITH
LOCATION 'foo.csv';
statement error DataFusion error: SQL error: ParserError\("Unexpected token
FOOBAR"\)
CREATE EXTERNAL TABLE t(c1 int) STORED AS CSV FOOBAR BARBAR BARFOO LOCATION
'foo.csv';
+# Missing partition column
Review Comment:
Positive case is already covered in the mod tests, don't think adding
another one in create_external_table.slt would be necessary. However, I think
e2e in insert_to_external.slt is a great idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
