korowa opened a new pull request, #9757:
URL: https://github.com/apache/arrow-datafusion/pull/9757
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
While #9676, found that at this moment `HashJoinExec` works incorrect in
case of LEFT / FULL types. Currently, construction of these joins is prevented
by physical optimizer join_selection rule. This PR adds support for all join
types in CollectLeft mode.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- `JoinLeftData` now contains bitmap with visited left indices and atomic
counter of total right-side threads (streams), updating this particular
`JoinLeftData` object (initial value will always be 1 for partitioned joins,
and "number of right-side partitions" for CollectLeft)
- In the beginning of `process_unmatched_build_batch`, when it's guaranteed
that there won't be any further updates of visited indices bitmap, each
`HashJoinStream` decrements the counter of running partitions by calling
`report_probe_completed`, and only the last caller-thread (determined by
counter value) will return unmatched left-side data
- Conditional logic for join types removed from `try_collect_left` in
join_selection rule
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, by adding test case for parallel (multiple right-side partitions) hash
join execution with CollectLeft partition mode
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
