alamb commented on code in PR #9760:
URL: https://github.com/apache/arrow-datafusion/pull/9760#discussion_r1536780487
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -660,11 +660,11 @@ enum ScalarFunction {
// 118 was ToTimestampNanos
// 119 was ArrayIntersect
// 120 was ArrayUnion
- OverLay = 121;
+ // 121 was OverLay
Review Comment:
wow we are pretty close to finishing this list 🤯
##########
datafusion/functions/Cargo.toml:
##########
@@ -75,6 +75,8 @@ log = { workspace = true }
md-5 = { version = "^0.10.0", optional = true }
regex = { version = "1.8", optional = true }
sha2 = { version = "^0.10.1", optional = true }
+uuid = { version = "1.7", features = ["v4"] }
Review Comment:
I think technically this could be an optional depdendece (on string
expressions) but since datafusion-core relies on uuid too. I'll try and clean
it up as a follow on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
