Lordworms commented on PR #9719: URL: https://github.com/apache/arrow-datafusion/pull/9719#issuecomment-2016800448
> Thanks for taking this @Lordworms > > One situation I came up with that makes eliminating common expr across plans tricky is how to keep track of column references. Consider a plan like: > > ``` > Projection: a+1 > --Projection: a+1 as a > ----TableScan > ``` > > Where two `a+1` are different things actually, since two `a` are not the same thing. The result is wrong if we replace them with a pre-computed common expr. Thanks, I'll record this and fix in the following PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
