helly25 commented on issue #40756:
URL: https://github.com/apache/arrow/issues/40756#issuecomment-2016936958
> > provide the version.txt
>
> So provide a path to an alternate versions.txt file via env or cmake var?
I like it!
Like that.
The versions file would probably better be split into 2. The top part that
can then be controlled via env or cmake and the second part that contains the
`DEPENDENCIES`. Only the file to be overloaded would have three vars per target
...`_BUILD_VERSION`, ...`_BUILD_SHA256` and ...`_BUILD_URL`.
Currently the lower part looks like this:
```
DEPENDENCIES=(
"ARROW_ABSL_URL absl-${ARROW_ABSL_BUILD_VERSION}.tar.gz
https://github.com/abseil/abseil-cpp/archive/${ARROW_ABSL_BUILD_VERSION}.tar.gz";
```
So the configureable versions.txt would only have entry sets like the
following:
```
ARROW_ABSL_BUILD_VERSION=20211102.0
ARROW_ABSL_BUILD_SHA256_CHECKSUM=dcf71b9cba8dc0ca9940c4b316a0c796be8fab42b070bb6b7cab62b48f0e66c4
ARROW_ABSL_BUILD_URL=https://github.com/abseil/abseil-cpp/archive/${ARROW_ABSL_BUILD_VERSION}.tar.gz
```
And the non configurable part would be something like:
```
DEPENDENCIES=(
"ARROW_ABSL_URL absl-${ARROW_ABSL_BUILD_VERSION}.tar.gz
${ARROW_ABSL_BUILD_URL}"
```
Maybe the file also needs to configurable or be constructed from the url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
