alamb commented on code in PR #9788:
URL: https://github.com/apache/arrow-datafusion/pull/9788#discussion_r1536988434
##########
datafusion/functions-array/README.md:
##########
@@ -21,7 +21,7 @@
[DataFusion][df] is an extensible query execution framework, written in Rust,
that uses Apache Arrow as its in-memory format.
-This crate contains functions for working with arrays, such as `array_append`
that work with
+This crate contains functions for working with arrays, such as `array_append`
that works with
Review Comment:
I think the original was more correct as `functions` is plural
##########
datafusion/functions-array/src/resize.rs:
##########
@@ -85,7 +86,9 @@ impl ScalarUDFImpl for ArrayResize {
}
/// array_resize SQL function
-pub fn array_resize_inner(arg: &[ArrayRef]) ->
datafusion_common::Result<ArrayRef> {
+pub(crate) fn array_resize_inner(
+ arg: &[ArrayRef],
+) -> datafusion_common::Result<ArrayRef> {
Review Comment:
Should we also change this to just `Result<ArrayRef>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
