mapleFU commented on code in PR #40768:
URL: https://github.com/apache/arrow/pull/40768#discussion_r1536993089
##########
cpp/src/parquet/file_writer.cc:
##########
@@ -140,37 +140,35 @@ class RowGroupSerializer : public
RowGroupWriter::Contents {
const int32_t column_ordinal = next_column_index_++;
const auto& path = col_meta->descr()->path();
+ const ColumnProperties& column_properties =
properties_->column_properties(path);
auto meta_encryptor =
file_encryptor_ ?
file_encryptor_->GetColumnMetaEncryptor(path->ToDotString())
: nullptr;
auto data_encryptor =
file_encryptor_ ?
file_encryptor_->GetColumnDataEncryptor(path->ToDotString())
: nullptr;
- auto ci_builder = page_index_builder_ &&
properties_->page_index_enabled(path) &&
- properties_->statistics_enabled(path)
+ auto ci_builder = page_index_builder_ &&
column_properties.page_index_enabled() &&
+ column_properties.statistics_enabled()
?
page_index_builder_->GetColumnIndexBuilder(column_ordinal)
: nullptr;
- auto oi_builder = page_index_builder_ &&
properties_->page_index_enabled(path)
+ auto oi_builder = page_index_builder_ &&
column_properties.page_index_enabled()
?
page_index_builder_->GetOffsetIndexBuilder(column_ordinal)
: nullptr;
- auto codec_options = properties_->codec_options(path)
- ? properties_->codec_options(path).get()
- : nullptr;
+ const CodecOptions* codec_options = column_properties.codec_options()
Review Comment:
I prefer explicit type since we know the type here and it's unlikely to be
changed. But we can wait for others comment here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
