jayzhan211 commented on issue #9787: URL: https://github.com/apache/arrow-datafusion/issues/9787#issuecomment-2017331043
> @jayzhan211 Thanks for reply. 1- Sure, we can revisit this in terms of our new requirements. 2- I was wondering if we need consistency between https://github.com/apache/arrow-datafusion/blob/main/datafusion/functions-array/src/empty.rs#L33 and https://github.com/apache/arrow-datafusion/blob/main/datafusion/functions-array/src/empty.rs#L58. In general, we use `array_*` prefix for array functions naming convention so should we rename `empty` with `array_empty` by aligning with other array functions? It is not big deal, just would double check. > > ``` > select empty(arrow_cast(make_array(1), 'LargeList(Int64)')); > ---- > false > ``` https://github.com/apache/arrow-datafusion/issues/7290 The name comes from clickhouse, so I think it is fine to name it without prefix`array`, but I think we can have an alias as `array_empty`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
