jorisvandenbossche commented on code in PR #40697:
URL: https://github.com/apache/arrow/pull/40697#discussion_r1537445397
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -183,22 +183,6 @@ liborc::RowReaderOptions default_row_reader_options() {
return options;
}
-// Proactively check the availability of timezone database.
-// Remove it once https://issues.apache.org/jira/browse/ORC-1661 has been
fixed.
-Status check_timezone_database_availability() {
- auto tz_dir = std::getenv("TZDIR");
- bool is_tzdb_avaiable = tz_dir != nullptr
Review Comment:
I would personally keep this check, as mentioned earlier
(https://github.com/apache/arrow/pull/40697#discussion_r1535231818), I think
it's important to provide am informative error message. And with this check, we
can easily improve the clarity of the error message a lot.
And as mentioned here, we can limit this to ORC < 2.0, to use ORC's better
handling when it is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
