jayzhan211 commented on code in PR #9249:
URL: https://github.com/apache/arrow-datafusion/pull/9249#discussion_r1537547049
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -517,7 +517,10 @@ impl AsExecutionPlan for PhysicalPlanNode {
}
AggregateFunction::UserDefinedAggrFunction(udaf_name) => {
let agg_udf =
registry.udaf(udaf_name)?;
-
udaf::create_aggregate_expr(agg_udf.as_ref(), &input_phy_expr,
&physical_schema, name)
+ // TODO: `order by` is not
supported for UDAF yet
+ let sort_exprs = &[];
Review Comment:
We need to convert `Vec<PhysicalSortExprNode>` to `Vec<Expr>`, not sure
should we included in this PR or not.
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -517,7 +517,10 @@ impl AsExecutionPlan for PhysicalPlanNode {
}
AggregateFunction::UserDefinedAggrFunction(udaf_name) => {
let agg_udf =
registry.udaf(udaf_name)?;
-
udaf::create_aggregate_expr(agg_udf.as_ref(), &input_phy_expr,
&physical_schema, name)
+ // TODO: `order by` is not
supported for UDAF yet
+ let sort_exprs = &[];
Review Comment:
We need to convert `Vec<PhysicalSortExprNode>` to `Vec<Expr>`, not sure
should we included it in this PR or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
