matthewmturner commented on issue #9558:
URL:
https://github.com/apache/arrow-datafusion/issues/9558#issuecomment-2018014421
> Note I think you could probably just add a single function and make the
change to the trait backwards compatible, for example
>
> ```rust
> pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
> /// return the name of this execution plan's type
> fn name(&self) -> &'static str { "UNKNOWN" }
> ...
> }
> ```
I think thats a great idea.
> Another option for an API that avoids string copying could be
>
> ```rust
> fn name(&self) -> Arc<str> ;
> ```
>
> To still allow dynamicc names
Do you have or know of existing use cases for dynamic names? I had in mind
that these names would always be known at compile time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
