peter-toth commented on issue #9637: URL: https://github.com/apache/arrow-datafusion/issues/9637#issuecomment-2018066737
Before https://github.com/apache/arrow-datafusion/pull/8891 I ran some experiments in https://github.com/apache/arrow-datafusion/pull/7942 with different APIs to test if transform/rewrite could in place mutate the nodes. In place mutation indeed seemed very effective, especially on `Expr` trees: https://github.com/apache/arrow-datafusion/pull/7942#issuecomment-1864247136. It brought less improvement on `LogicalPlan` trees: https://github.com/apache/arrow-datafusion/pull/7942#issuecomment-1866908166 but I tested the case when a reference is kept to the original tree so the `Arc::try_unwrap` trick wouldn't work there... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
