pitrou commented on code in PR #40299:
URL: https://github.com/apache/arrow/pull/40299#discussion_r1537667545
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -990,10 +1122,20 @@ class ClientBuilder {
client_config_.maxConnections =
std::max(io_context->executor()->GetCapacity(), 25);
}
+ const bool use_virtual_addressing =
+ options_.endpoint_override.empty() ||
options_.force_virtual_addressing;
+
+#ifdef ARROW_S3_HAS_S3CLIENT_CONFIGURATION
+ client_config_.useVirtualAddressing = use_virtual_addressing;
Review Comment:
No. We just had to pass the argument on older verisons:
https://github.com/aws/aws-sdk-cpp/blob/ffd81252bec92f3e0587e144b07c05f8aed28eb1/aws-cpp-sdk-s3/include/aws/s3/S3Client.h#L460-L465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
