korowa opened a new pull request, #9800:
URL: https://github.com/apache/arrow-datafusion/pull/9800

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   While #9676 found that NLJoin input reordering in benchmarks doesn't happen 
if one of inputs is AntiJoin -- the reason is that output statistics for all 
Semi/Anti join types is always set as `Absent`. This PR propagates "outer" 
input statistics to Anti/Semi join output.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   - "outer" input statistics for Anti/Semi join cases is now propagated as 
output statistics (worst case  assumption -- filtering not occurs at all, an 
alternative might be either to use `default_filter_statistics` or use similar 
to regular joins algorithm based on estimated distinct values, which though 
could be misleading as it assumes that "all values from smaller side are 
present in larger side" -- not sure if it's fine for filter estimation)
   - the only exception is disjoint inputs case -- if inputs statistics values 
are non-overlapping, the output cardinality will be estimated as zero
   - avoid early returns on absent statistics value while non-overlapping 
statistics checks
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   Added test coverage for SemiJoin cardinality estimation
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   Execution plans containing Semi/Anti joins might change
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to