tustvold commented on code in PR #5525:
URL: https://github.com/apache/arrow-rs/pull/5525#discussion_r1538321869
##########
arrow-ipc/src/writer.rs:
##########
@@ -547,6 +564,53 @@ impl IpcDataGenerator {
}
}
+fn append_variadic_buffer_counts(counts: &mut Vec<i64>, array: &dyn Array) {
Review Comment:
If we keep this method perhaps we could traverse the nested hierarchy using
`child_data` instead of explicitly matching `array.data_type()` this should at
least make the logic easier to follow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
