kou commented on code in PR #40771:
URL: https://github.com/apache/arrow/pull/40771#discussion_r1538490727
##########
dev/merge_arrow_pr.py:
##########
@@ -680,6 +683,19 @@ def prompt_for_fix_version(cmd, issue,
maintenance_branches=()):
maintenance_branches=maintenance_branches
)
+ if (issue.current_fix_versions and
+ issue.current_fix_versions != default_fix_version):
+ print("\n=== The assigned milestone is not the default ===")
+ print(f"Assigned milestone: {issue.current_fix_versions}")
+ print(f"Current milestone: {default_fix_version}")
+ print("Please ensure to assign the correct milestone.")
+ if issue.issue["milestone"].get("state") == 'closed':
+ print("The assigned milestone state is closed. Contact the ")
+ print("Release Manager if it has to be added to a closed Release")
+ print("Please ensure to assign the correct milestone.")
Review Comment:
Can we remove duplicated messages? (`Please ensure to assign the correct
milestone.`)
##########
dev/merge_arrow_pr.py:
##########
@@ -680,6 +683,19 @@ def prompt_for_fix_version(cmd, issue,
maintenance_branches=()):
maintenance_branches=maintenance_branches
)
+ if (issue.current_fix_versions and
+ issue.current_fix_versions != default_fix_version):
+ print("\n=== The assigned milestone is not the default ===")
+ print(f"Assigned milestone: {issue.current_fix_versions}")
+ print(f"Current milestone: {default_fix_version}")
+ print("Please ensure to assign the correct milestone.")
+ if issue.issue["milestone"].get("state") == 'closed':
+ print("The assigned milestone state is closed. Contact the ")
+ print("Release Manager if it has to be added to a closed Release")
+ print("Please ensure to assign the correct milestone.")
+ # Default to existing assigned milestone
+ default_fix_version = issue.current_fix_versions
Review Comment:
It seems that we need a HTTP request for each `issue.current_fix_version`
call. Can we avoid it?
```suggestion
current_fix_versions = issue.current_fix_versions
if (current_fix_versions and
current_fix_versions != default_fix_version):
print("\n=== The assigned milestone is not the default ===")
print(f"Assigned milestone: {current_fix_versions}")
print(f"Current milestone: {default_fix_version}")
print("Please ensure to assign the correct milestone.")
if issue.issue["milestone"].get("state") == 'closed':
print("The assigned milestone state is closed. Contact the ")
print("Release Manager if it has to be added to a closed
Release")
print("Please ensure to assign the correct milestone.")
# Default to existing assigned milestone
default_fix_version = current_fix_versions
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
