wgtmac commented on code in PR #40732:
URL: https://github.com/apache/arrow/pull/40732#discussion_r1538508126
##########
cpp/src/parquet/encryption/file_key_unwrapper.cc:
##########
@@ -30,33 +30,37 @@ FileKeyUnwrapper::FileKeyUnwrapper(
const std::string& file_path,
const std::shared_ptr<::arrow::fs::FileSystem>& file_system)
: FileKeyUnwrapper(std::move(key_toolkit), /*key_toolkit=*/nullptr,
- kms_connection_config, cache_lifetime_seconds,
file_path,
- file_system) {}
+ kms_connection_config, cache_lifetime_seconds,
+ /*key_material_store=*/nullptr, file_path, file_system)
{}
FileKeyUnwrapper::FileKeyUnwrapper(
KeyToolkit* key_toolkit, const KmsConnectionConfig& kms_connection_config,
double cache_lifetime_seconds, const std::string& file_path,
const std::shared_ptr<::arrow::fs::FileSystem>& file_system)
: FileKeyUnwrapper(/*key_toolkit_owner=*/nullptr, key_toolkit,
kms_connection_config,
- cache_lifetime_seconds, file_path, file_system) {}
+ cache_lifetime_seconds, /*key_material_store=*/nullptr,
file_path,
+ file_system) {}
FileKeyUnwrapper::FileKeyUnwrapper(
KeyToolkit* key_toolkit, const KmsConnectionConfig& kms_connection_config,
double cache_lifetime_seconds,
std::shared_ptr<FileKeyMaterialStore> key_material_store)
: FileKeyUnwrapper(/*key_toolkit_owner=*/nullptr, key_toolkit,
kms_connection_config,
- cache_lifetime_seconds, /*file_path=*/"",
+ cache_lifetime_seconds, std::move(key_material_store),
Review Comment:
I agree with the current change to fix the missing argument instead of
removing a public function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
