mapleFU commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r1539284937
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1603,6 +1611,7 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
public TypedColumnWriter<
if (page_statistics_ != nullptr) {
page_statistics_->Update(values, num_values, num_nulls);
}
+ UpdateBloomFilter(values, num_values);
Review Comment:
Emmm should we first create an issue for that and implement it first? Seems
page_statistics or other can also be extract into it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
