danepitkin commented on code in PR #40786:
URL: https://github.com/apache/arrow/pull/40786#discussion_r1539334638


##########
dev/conbench_envs/benchmarks.env:
##########
@@ -48,3 +48,4 @@ PARQUET_BUILD_EXAMPLES=ON
 PARQUET_BUILD_EXECUTABLES=ON
 PYTHON=python
 LD_LIBRARY_PATH=$CONDA_PREFIX/lib:$LD_LIBRARY_PATH
+JAVA_OPTIONS=-Xmx8G

Review Comment:
   For Xms, I don't think it's necessary.
   
   This can be passed in as cli args, too! We can add it as `--java-options 
-Xmx8G` in a different repo here: 
https://github.com/voltrondata-labs/benchmarks/blob/231078e715001c32d2f4ef2ffca27abb4625fd21/benchmarks/java_micro_benchmarks.py#L47-L58
   
   For now, I'm using this method just to test more easily.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to