lidavidm commented on code in PR #404:
URL: https://github.com/apache/arrow-nanoarrow/pull/404#discussion_r1539391746
##########
src/nanoarrow/utils_test.cc:
##########
@@ -538,3 +538,36 @@ TEST(DecimalTest, DecimalRoundtripBitshiftTest) {
ArrowBufferReset(&buffer);
}
+
+TEST(MaybeTest, ConstructionAndConversion) {
+ // NOTE these will not print nicely in GTest unless we write PrintTo,
Review Comment:
I think it would work to define PrintTo in a different header + compilation
unit that you could include only in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
