jorisvandenbossche commented on PR #40717: URL: https://github.com/apache/arrow/pull/40717#issuecomment-2020889386
Thanks for testing! > the only difference I see is that the device_id for the CPU is -1. I can't find in the spec exactly what it should be...is -1 the accepted value? That's a good point. In practice this comes from our implementation in C++: https://github.com/apache/arrow/blob/434f87274e8e9adab4f0434ae494f30dc955ca6e/cpp/src/arrow/device.h#L82-L86 But we should probably clarify that in the spec whether that's allowed / expected. I see that DLPack actually specified that as to be 0 for CPU: https://dmlc.github.io/dlpack/latest/c_api.html#c.DLDevice.device_id Maybe we should follow that; will open a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
