erratic-pattern commented on code in PR #5433:
URL: https://github.com/apache/arrow-rs/pull/5433#discussion_r1539734582
##########
arrow-flight/src/sql/client.rs:
##########
@@ -519,17 +521,37 @@ impl PreparedStatement<Channel> {
.await
.map_err(flight_error_to_arrow_error)?;
- self.flight_sql_client
+ // Attempt to update the stored handle with any updated handle in
the DoPut result.
+ // Not all servers support this, so ignore any errors when
attempting to decode.
Review Comment:
> The comment says errors are ignored, but the code doesn't seem to ignore
errors. I wonder if I am misreading this or if the comment or code should be
updated 🤔
comments never lie ;)
updated this to explain that we ignore the lack of a response from legacy
servers, rather than any error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
