pitrou commented on code in PR #40699:
URL: https://github.com/apache/arrow/pull/40699#discussion_r1539734350
##########
cpp/src/arrow/device.h:
##########
@@ -363,4 +363,33 @@ class ARROW_EXPORT CPUMemoryManager : public MemoryManager
{
ARROW_EXPORT
std::shared_ptr<MemoryManager> default_cpu_memory_manager();
+using MemoryMapper =
+ std::function<Result<std::shared_ptr<MemoryManager>>(int64_t device_id)>;
Review Comment:
Sorry, but a couple more suggestions to unify naming:
1. rename `MemoryMapper` to `DeviceMemoryMapper`?
2. rename `RegisterDeviceMemoryManager` to `RegisterDeviceMemoryMapper`
3. rename `GetDeviceMemoryManager` to `GetDeviceMemoryMapper`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
